yarnpkg/yarn

Yarn publish reports success despite request failing

Open

#5 931 ouverte le 5 juin 2018

Voir sur GitHub
 (2 commentaires) (6 réactions) (1 assigné)JavaScript (41 514 stars) (2 731 forks)batch import
cat-bughelp wantedhigh-priority

Description

Do you want to request a feature or report a bug? bug

What is the current behavior? When running yarn publish, Yarn reports success Published. after having a 400 error code returned on the PUT request

If the current behavior is a bug, please provide the steps to reproduce. The registry is returning 400 on the PUT request. I'm not sure at this time why our registry is returning a 400.

What is the expected behavior? The command should report back to the user that the publishing was not successful.

Please mention your node.js, yarn and operating system version. node v9.11.1 yarn v1.7.0 OS Ubuntu 18.04

image

Guide contributeur

Stack technique
javascript
Domaine
cli
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Node.jsyarn internalsHTTP client handling
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
50
Direction de recherche
Investigate the publish command flow in yarn, particularly the handling of HTTP responses when making PUT requests to the registry. Look at the code that prints the success message after a publish attempt. The issue suggests that a 400 error from the registry is not being properly propagated, leading to a misleading success message. Check the source files under src/cli/commands/publish.js or similar, and trace the response handling after the PUT request. Consider how the registry URL is constructed and whether error codes are checked.