xamarin/Xamarin.Forms
[UWP] Skipping setting "default values" for element properties in renderers is problematic
Ouverte
#4 312 ouverte le 5 nov. 2018
e/6 :clock6:help wantedinactivep/UWPt/bug :bug:up-for-grabs
Métriques du dépôt
- Stars
- (5 644 étoiles)
- Métriques de merge PR
- (Métriques PR en attente)
Description
Is checking of default values really necessary in renderers?:
If ... Element.Padding != Button.PaddingProperty.DefaultValue ... UpdatePadding();
The default padding value for a Xamarin button is (0,0,0,0), while the default padding for a UWP button is (8,4,8,4). (https://msdn.microsoft.com/en-us/library/windows/apps/mt299109.aspx)
This means that if I set padding (0,0,0,0) on a Xamarin button, and I really want it to be (0,0,0,0) on UWP, the renderer will skip setting the padding property. And my UWP button will have a (8,4,8,4) padding, which is not my intent!
Does checking and skipping default property values in renderers have any meaningful purpose? It seems to me that it creates more problems than it solves.