winglang/wing
Voir sur GitHubConfusion around `util.env` and `util.tryEnv` in preflight vs inflight contexts
Open
#4 601 ouverte le 19 oct. 2023
good first issue🎨 sdk🐶 dogfood
Métriques du dépôt
- Stars
- (5 385 stars)
- Métriques de merge PR
- (Aucune PR mergée en 30 j)
Description
The util.env and util.tryEnv utilities work differently in preflight and inflight contexts.
Given the following example:
MY_VAR=123 wing compile main.w
// main.w
bring cloud;
bring util;
log(util.env("MY_VAR")); // Logs 123
let MY_VAR = util.env("MY_VAR");
new cloud.Function(inflight () => {
log(util.tryEnv("MY_VAR") ?? "<no value>"); // Logs <no value>
log(MY_VAR); // Logs 123
});
The Cloud Function util.tryEnv is being translated into a lookup to process.env rather than use the host's environment variables. I find this behaviour confusing, maybe even unnecessary. Do we need to access environment variables in inflight functions? The only environment variables we can specify are when invoking the Wing CLI.
IMO, log(util.tryEnv("MY_VAR") ?? "<no value>"); should log 123 as well, with the actual inflight code being inlined as log("123" ?? "<no value>"); (it could even be simplified to log("123")).