Regression: dynamic runtime `require` works in 0.38.1 but breaks in 0.38.2

(2 commentaires) (0 réaction) (0 personne assignée)JavaScript (273 forks)batch import

help wanted

Métriques du dépôt

Stars: (8 841 étoiles)
Métriques de merge PR: (Merge moyen 31j 15h) (7 PRs mergées en 30 j)

Description

0.38.1

I have the following source code:

https://github.com/CatChen/eslint-suggestion-action/blob/930479a34a06bfa384291cc877f9d1ce21533ae1/src/getESLint.ts#L16-L19

The dynamic require is compiled into the following code:

https://github.com/CatChen/eslint-suggestion-action/blob/930479a34a06bfa384291cc877f9d1ce21533ae1/bundle/index.js#L37587

0.38.2

The same code is compiled into the following code since 0.38.2:

https://github.com/CatChen/eslint-suggestion-action/blob/bc0de7fa625de9daf56cca84b6084f4d6bcbaca4/bundle/index.js#L37702

Workaround

My current workaround is to use dynamic import inside a new Function() (because dynamic import isn't supported either). I have to change to code into this:

https://github.com/CatChen/eslint-suggestion-action/blob/927208b2e684b1a7c721f4a0e70d4f4e8c11c228/src/getESLint.ts#L15-L26

Guide contributeur

Direction de recherche: Comparez la sortie groupée entre les versions 0.38.1 et 0.38.2 pour le modèle de require dynamique. Identifiez ce qui a changé dans la gestion des require dynamiques par ncc et localisez la modification de code qui a causé la régression.
Stack technique: javascript
Domaine: build system
Type d'issue: Bug
Difficulté: 3
Temps estimé: Une demi journée
Statut d'activité: Active
Clarté: Claire
Prérequis: JavaScriptNode.jsncc
Accessibilité débutant: 40