vercel/ncc

would you be open to support node[[X].Y] as target to make GitHub Action build artifacts smaller?

Open

#1 247 ouverte le 27 janv. 2025

Voir sur GitHub
 (6 commentaires) (1 réaction) (0 assignés)JavaScript (8 841 stars) (273 forks)batch import
help wanted

Description

in the light of 1246 I discovered default target is es2025 and it only es* targets are expected. underlying webpack does support node* as a target, but ncc restricts it. but using es version as a target doesn't make sense for nodejs versions, because es support is fragmented.

I'd like to relax es* only target restriction to include node* as well, to make GitHub Action build artifacts smaller by not transpiling everything to es2015 but rather only to what's missing in node20 for example

Guide contributeur

Stack technique
javascriptnodejs
Domaine
build systemtoolingci cd
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
active
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Node.jsJavaScriptncc basicswebpack targets
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
35
Direction de recherche
Start by examining the source code of ncc to locate where target validation occurs (likely in the webpack configuration). Look at issue #1246 for context on why targets matter. Check the existing allowed targets list and consider extending it to include node versions. Review any webpack documentation on node targets. The PR should update the validation to accept node versions and possibly adjust the default target based on environment.