vectordotdev/vector

metrics: rename memory enrichment table counters to end with _total

Open

#25 455 ouverte le 18 mai 2026

Voir sur GitHub
 (4 commentaires) (0 réactions) (0 assignés)Rust (21 837 stars) (2 126 forks)batch import
domain: enrichment_tablesdomain: metricsgood first issuesource: internal_metrics

Description

Summary

Three counter metrics in the memory enrichment table are missing the _total suffix, violating the instrumentation spec.

From docs/specs/instrumentation.md: "Counters MUST end with total"

Metrics to rename

Current name Correct name
memory_enrichment_table_failed_insertions memory_enrichment_table_failed_insertions_total
memory_enrichment_table_failed_reads memory_enrichment_table_failed_reads_total
memory_enrichment_table_ttl_expirations memory_enrichment_table_ttl_expirations_total

These are defined in lib/vector-common/src/internal_event/metric_name.rs as CounterName variants. Their descriptions already say "The total number of..." confirming the intent was to follow the _total convention.

Notes

These are breaking changes for anyone scraping these metrics directly. The old names should be kept as deprecated aliases or the rename should be accompanied by a changelog entry.

Guide contributeur

Stack technique
rust
Domaine
observability
Type d'issue
refactor
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
1
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
under 1 hour
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Rust programmingVector internals
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
95
Direction de recherche
The issue involves renaming CounterName variants in lib/vector common/src/internal event/metric name.rs. The specification in docs/specs/instrumentation.md requires counters to end with ' total'. The renames are straightforward. The issue suggests keeping old names as deprecated aliases or adding a changelog entry, which should be considered but is not required for the core fix.