metrics: rename memory enrichment table counters to end with _total · vectordotdev/vector#25455

(5 commentaires) (0 réactions) (0 assignés)Rust (2 126 forks)batch import

domain: enrichment_tablesdomain: metricsgood first issuesource: internal_metrics

Métriques du dépôt

Stars: (21 837 stars)
Métriques de merge PR: (Merge moyen 8j 16h) (110 PRs mergées en 30 j)

Description

Summary

Three counter metrics in the memory enrichment table are missing the _total suffix, violating the instrumentation spec.

From docs/specs/instrumentation.md: "Counters MUST end with total"

Metrics to rename

Current name	Correct name
`memory_enrichment_table_failed_insertions`	`memory_enrichment_table_failed_insertions_total`
`memory_enrichment_table_failed_reads`	`memory_enrichment_table_failed_reads_total`
`memory_enrichment_table_ttl_expirations`	`memory_enrichment_table_ttl_expirations_total`

These are defined in lib/vector-common/src/internal_event/metric_name.rs as CounterName variants. Their descriptions already say "The total number of..." confirming the intent was to follow the _total convention.

Notes

These are breaking changes for anyone scraping these metrics directly. The old names should be kept as deprecated aliases or the rename should be accompanied by a changelog entry.

Guide contributeur

Direction de recherche: Trouvez l'énumération CounterName dans lib/vector common/src/internal event/metric name.rs, renommez les trois variantes pour qu'elles se terminent par total, et assurez vous que les anciens noms soient conservés comme alias dépréciés conformément à la spécification.
Stack technique: rust
Domaine: backend
Type d'issue: Bug
Difficulté: 2
Temps estimé: 1-3 heures
Statut d'activité: Active
Clarté: Claire
Prérequis: Git
Accessibilité débutant: 75