valyala/fasthttp

Recommendation on cleaning of HostClient.

Fermée

#726 ouverte le 12 janv. 2020

 (2 commentaires) (0 réaction) (0 personne assignée)Go (1 755 forks)batch import
help wantedquestion

Métriques du dépôt

Stars
 (21 741 étoiles)
Métriques de merge PR
 (Merge moyen 3j) (44 PRs mergées en 30 j)

Description

As of now the only way to override Host header is to use HostClient as per Issue 318. This means we have to manage reusing/cleanup of HostClients ourselves which fasthttp.Client provided out of the box.

We will be writing something very similar to fasthttp.Client to handle this. Is it ok to remove the HostClient if it is not being used from more than MaxIdleConnDuration*2 or something, as we are sure all goroutines for individual connection cleaning would have run? We don't have access to connsCount as it is an unexported field and was modified to use connsCount instead of time.

if t.Sub(v.LastUseTime()) > (MaxIdleConnDuration*2) {
				delete(m, k)
			}

If not, what is the recommendation here?

Guide contributeur