valkey-io/valkey
[BUG] A large negative number(e.g. -LONG_MAX) in HRANDFIELD/ZRANDMEMBER can easily cause Valkey to crash.
Fermée
#844 ouverte le 30 juil. 2024
good first issuehelp wanted
Métriques du dépôt
- Stars
- (25 779 étoiles)
- Métriques de merge PR
- (Merge moyen 17j 7h) (74 PRs mergées en 30 j)
Description
Describe the bug
When using the HRANDFIELD or ZRANDMEMBER commands, if an extremely negative value(e.g. -LONG_MAX) is provided, the memory will continue to rise and eventually cause Redis to crash.
To reproduce
HRANDFIELD hash -9223372036854775807
Expected behavior
IMHO, it is more reasonable to set a limit on count according to the memory limit or the actual size of the hash table to prevent Redis from crashing. This can prevent crashes caused by careless and incorrect use. If a user really needs to sample a lot of elements that allow duplicates, he can achieve the same purpose by calling the command multiple times.