valkey-io/valkey

Updated CI testing to improve catching tests early.

Fermée

#625 ouverte le 11 juin 2024

 (0 commentaire) (0 réaction) (0 personne assignée)C (1 138 forks)batch import
help wanted

Métriques du dépôt

Stars
 (25 779 étoiles)
Métriques de merge PR
 (Merge moyen 17j 7h) (74 PRs mergées en 30 j)

Description

We have had a recent string of issues with regressions being introduced into the daily rest run, that weren't being caught in the daily. After reviewing the daily failures, me and some other contributors came up with the following recommendation.

  1. Add in a second test suite that uses an allocator that is not jemalloc that has "no malloc size" enabled.
  2. Add a new CI target tests with TLS, but skip all of the "slow" tests. Included here is that we should add a slow tag to the payload fuzzer as they take a significant amount of time with TLS.
  3. Add a build target that actually builds the legacy unit test, to make sure they compile correctly.

We also discussed maybe adding in the sentinel tests as part of the build, however it wasn't clear if they regularly caught issues.

Guide contributeur