validatorjs/validator.js

Mobile Phone validations - For The First Time Contributors

Open

#1 761 ouverte le 8 oct. 2021

Voir sur GitHub
 (113 commentaires) (10 réactions) (0 assignés)JavaScript (2 253 forks)batch import
enhancementgood first issue

Métriques du dépôt

Stars
 (22 497 stars)
Métriques de merge PR
 (Merge moyen 10h 14m) (2 PRs mergées en 30 j)

Description

I would like to give this to the people who are new and would like to start contributing to validator.js.

The current version in isMobilePhone validation, we have less than 195 phone validations i.e

In the code https://github.com/validatorjs/validator.js/blob/master/src/lib/isMobilePhone.js, the validations exist from line 5 to line 119, which means we have probably 119 - 5 countries phone validations. Where might be other countries? That is up to someone who would like to choose which country does not exist and create a new validation for the same.

When making this change, apart from the file above, also add tests and update the isMobilePhone section in the README.

Also, please check on existing PR's if the country you choose to validate mobile phone numbers does not have an already PR raised.

All Prs are welcomed and we will do a review on the same

Guide contributeur