vaadin/framework

Deprecate MultiSelectionEvent.getNewSelection

Ouverte

#11 756 ouverte le 23 oct. 2019

 (1 commentaire) (1 réaction) (0 personne assignée)Java (715 forks)auto 404
Help wantedStale

Métriques du dépôt

Stars
 (1 806 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Description copied from https://github.com/vaadin/flow/issues/6756

The class has three methods for the same thing:

Set<T> getValue()
Set<T> getAllSelectedItems()
Set<T> getNewSelection()

The first two are inherited, but getNewSelection exists only in MultiSelectionEvent.

Another reason to deprecate it is that the naming can cause confusion. We got feedback that a user expected the method to return the newly added items (compared to the old selection), i.e. what getAddedSelection returns.

JavaDocs should suggest to use getAllSelectedItems or getValue instead.

Guide contributeur