twitter/finagle

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

Open

#526 ouverte le 13 juil. 2016

Voir sur GitHub
 (6 commentaires) (0 réactions) (0 assignés)Scala (1 435 forks)batch import
good first issue

Métriques du dépôt

Stars
 (8 864 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

Guide contributeur