testcontainers/testcontainers-java
Voir sur GitHub[Feature]: Presto Module uses the outdated Docker Image of `ghcr.io/trinodb/presto` and needs to be updated to `prestodb/presto`
Open
#8 657 ouverte le 21 mai 2024
help wantedtype/feature
Métriques du dépôt
- Stars
- (7 535 stars)
- Métriques de merge PR
- (Merge moyen 2j 17h) (2 PRs mergées en 30 j)
Description
Module
Presto
Problem
-
Presto Module uses the outdated Docker Image of
ghcr.io/trinodb/prestoand needs to be updated toprestodb/presto. -
Refer to https://github.com/testcontainers/testcontainers-java/blob/1.19.8/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java and https://github.com/orgs/trinodb/packages/container/package/presto .
ghcr.io/trinodb/prestohas not been updated in 3 years. -
I'm confused by the instructions at https://java.testcontainers.org/modules/databases/presto/ .
This module is deprecated, use Trino module.
- The problem is, development of
prestohas been active, see https://hub.docker.com/r/prestodb/presto and https://github.com/prestodb/presto .
Solution
- Use
prestodb/prestoinstead ofghcr.io/trinodb/prestoinorg.testcontainers.containers.PrestoContainer.
Benefit
- This would obviously clarify the current situation regarding Presto. Presto is still maintained normally, so the corresponding testcontainers module should not be marked as deprecated.
Alternatives
- Maybe not. I'm not sure why
ghcr.io/trinodb/prestowas used initially.
Would you like to help contributing this feature?
No