Deprecate upsert with a key (from tarantool 1.6.6)
#248 ouverte le 22 nov. 2019
Métriques du dépôt
- Stars
- (52 étoiles)
- Métriques de merge PR
- (Métriques PR en attente)
Description
Tarantool-java version: 1.9.3.
Cited from Tarantool 1.6.7 release notes:
The syntax of
upsertcommand has been changed and an extrakeyargument was removed from it. The primary key for look up is now always taken from the tuple, which is the second argument of upsert.upsert()was added fairly late at a release cycle and the design had an obvious bug which we had to fix. Sorry for this.
See also https://github.com/tarantool/tarantool/issues/1070
The connector provides upsert() method with a key argument:
This is harmless, because those arguments are packed into a map and deprecated key field is ignored by tarantool 1.6.7 and above. However this API can confuse a user.
I propose to overload upsert method w/o key argument to don't bother a user with providing some value for key. This will also save some CPU cycles on encoding a request and several bytes in outgoing packets.
We also should cleanly state in javadoc that the old upsert method is deprecated and should be used only for tarantool 1.6.6 and below. We cannot remove the method, because the connector should be backward compatible.