swiftlang/swift

Improve the error message for passing `(any P)?` to `(some P)?`

Open

#61 733 ouverte le 26 oct. 2022

Voir sur GitHub
 (27 commentaires) (1 réaction) (1 assigné)Swift (10 719 forks)batch import
Optionalcompilerdiagnostics qualityexistentialsgenericsgood first issuetype checker

Métriques du dépôt

Stars
 (69 989 stars)
Métriques de merge PR
 (Merge moyen 8j 17h) (510 PRs mergées en 30 j)

Description

If you try to pass a value of type (any P)? to an argument of type (some P)?, the compiler tells you that any P cannot conform to P, which is confusing and not actionable. With SE-0375, existential opening/unboxing is supported with optionals, but only if the argument is not an optional because it's possible that the (any P)? is nil (and thus does not have a dynamic type to bind to some P). With SE-0375, the fix is to unwrap the optional or provide a default value. So, the error message should tell you that!

protocol P {}

struct S: P {}

func takesOptionalP(_: (some P)?) {}

func passOptional(value: (any P)?) {
  takesOptionalP(value) // error: type 'any P' cannot conform to 'P'

  takesOptionalP(value ?? S()) // okay under SE-0375
  takesOptionalP(value!) // okay under SE-0375
}

The constraint system currently applies the MissingConformance fix when solving for the takesOptionalP(value) expression. Instead, it should identify that the wrapped type of the argument matches the parameter type, and apply the ForceOptional fix.

Guide contributeur