swiftlang/swift

[SR-1553] [QOI] Warn on discarded binding of () result

Ouverte

#44 162 ouverte le 18 mai 2016

 (13 commentaires) (0 réaction) (0 personne assignée)Swift (10 719 forks)batch import
compilerdiagnostics qualitygood first issueimprovement

Métriques du dépôt

Stars
 (69 989 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Previous ID SR-1553
Radar None
Original Reporter @ddunbar
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI
Assignee zsalloum (JIRA)
Priority Medium

md5: a541dcf4281d920a0880df5d3eabc2fa

Issue Description:

Swift should warn on the code below:

$ cat x.swift
func f0() -> () {}
let _ = f0()

$ swiftc -c x.swift
$

This is somewhat related to SE-0047, in that if you use let _ = ... to discard results, and then later refactor the code to not return a result, Swift won't help you find the other places in the code base to update.

Guide contributeur