swagger-api/swagger-ui
Voir sur GitHubmake component names case insensitive. ie: getComponent("fooBaR")
Open
#3 393 ouverte le 15 juil. 2017
Good first issuepull-request-welcometype: feature
Métriques du dépôt
- Stars
- (25 447 stars)
- Métriques de merge PR
- (Merge moyen 20h 34m) (14 PRs mergées en 30 j)
Description
The plugin system exposes a way to get components via system.getComponent().
Up till now its been case sensitive. Unfortunately we never put in a style-guide on what case to use.
So we have lowercase, TitleCase components mixed throughout.
I propose we make them case-insensitive.
- When building the system, we store the downcased name of the component in our object.
- When fetching, we downcase the argument to getComponent in order to fetch it from our object.
eg:
//...
plugins = [ { components: { wONderBAR: () => <h1> Hi </h1> } } ]
// stored as { wonderbar: .... }
system.getComponent("wonderBAR") // the component keyed with "wonderbar"
This is to allow any case, and not break any existing code. That said, we should likely normalize the component names in this codebase to be consistent.