swagger-api/swagger-codegen

[JaxRsCxfServer] Improvements for generated Unittests and Attachments

Open

#4 513 ouverte le 6 janv. 2017

Voir sur GitHub
 (5 commentaires) (0 réactions) (0 assignés)HTML (5 474 forks)batch import
Enhancement: GeneralServer: Javahelp wanted

Métriques du dépôt

Stars
 (12 701 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Description

From #4088:

1.) currently in the tests the api invocations are commented out and thus cannot be compiled. Wouldn't it be good to activate them and run the CI maven build with -DskipTests?

2.) Handling CXF Attachments is not totally intuitive, do you think it makes sense to add an assistance snippet here like this at api_test.mustache (for #isFile):

InputStream mybytesInput = new FileInputStream("....");
org.apache.cxf.jaxrs.ext.multipart.ContentDisposition cd = new org.apache.cxf.jaxrs.ext.multipart.ContentDisposition("attachment;filename=file.txt");
Attachment attachment = new Attachment("file", mybytesInput, cd);

or does that go too far and we should leave with the default Attachment attachment = null;?

Swagger-codegen version

2.2.2-SNAPSHOT

Related issues

#4088 Minor improvements JaxRsCXFServer

Suggest a Fix

Guide contributeur