[Bug]: incorrectly build preview when use pnpm with custom virtual store directory
#20 211 ouverte le 12 déc. 2022
Métriques du dépôt
- Stars
- (89 909 étoiles)
- Métriques de merge PR
- (Merge moyen 7j 22h) (184 PRs mergées en 30 j)
Description
Describe the bug
When use latest version of pnpm with .npmrc like this:
store-dir=${HOME}/.some-folder/pnpm-store
virtual-store-dir=${HOME}/.some-folder/pnpm-virtual-store
About store-dir and virtual-store-dir.
So in case when my node modules located somewhere outside the project then used babel-loader for preview - https://github.com/storybookjs/storybook/blob/7a86f0363ef184a80437b7abf98e98d86e821f75/code/lib/builder-webpack5/src/preview/babel-loader-preview.ts defines include property incorrectly. As a result babel-loader not transpile my storybook components and I got some TS error.
The problem in this getProjectRoot method - https://github.com/storybookjs/storybook/blob/7035ea7389393da041985ebc491ee58dedb50d06/code/lib/core-common/src/utils/paths.ts#L4-L29. It founds node_modules inside my virtual store in home and thinks that my components located in one directory up.
To fix this problem, I need to change include option for babel-loader inside webpackFinal.
Another bug with this method - https://github.com/storybookjs/storybook/issues/14042
To Reproduce
No response
System
No response
Additional context
No response