someshkar/covid19india-cluster

Highlighting the Patient Number Searched

Open

#177 ouverte le 30 mars 2020

Voir sur GitHub
 (2 commentaires) (0 réactions) (0 assignés)JavaScript (991 stars) (666 forks)batch import
good first issue

Description

Hi! While this looks amazing, calling out a small issue that I felt while searching patient was as follows:

  • The resolution of the graph can be reduced a little, often the patient searched goes out of screen (SS-1 as below), image I had to zoom out manually to see the search result. (SS-2 as below) image

  • The Patient searched can be highlighted with a light background color as well to enhance the visiblity.

Guide contributeur

Stack technique
javascript
Domaine
frontend
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
basic understanding of graph rendering in JavaScript
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
70
Direction de recherche
Look at the graph component files, likely in the src directory, to understand how patient nodes are rendered and zoom is handled. The issue requests two changes: reducing graph resolution to prevent the searched patient from going off screen, and highlighting the searched patient with a light background. Consider adjusting the camera/zoom behavior to center on the selected node, and adding a CSS class or style to highlight the node. Check if there are any existing similar implementations or comments from maintainers.