smpallen99/coherence

Decoupling controller functionality

Open

#324 ouverte le 17 janv. 2018

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)Elixir (220 forks)batch import
enhancementhelp wanted

Métriques du dépôt

Stars
 (1 259 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Hey,

I'm very interested in coherence and the functionality it provides, however, I'd like to experiment with combining its functionality with other frameworks, for example ueberauth, or just in the case where I would like to use my customer controllers.

I have noticed that a lot of the meat is inside the coherence controllers, for example in order to fully create a new session you require to use Coherence.SessionController.create/2. Would it be a good idea to separate this functionality into a separate module so it could be used outside of coherence?

If this seems sensible I could start with a PR to pull out session functionality? I'm not 100% sure what the *_service.ex modules are intended for, but this would be a place I'd refactor the functionality to.

How does this sound?

Guide contributeur