sindresorhus/update-notifier

Notification is only displayed at most once per interval

Ouverte

#209 ouverte le 1 juil. 2021

 (3 commentaires) (0 réaction) (0 personne assignée)JavaScript (164 forks)user submission
enhancementhelp wanted

Métriques du dépôt

Stars
 (1 800 étoiles)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

As of 5.1.0, notifications are displayed at most once per interval period, because the fetched update is deleted once "emitted" (ie set to this.update)

		this.update = this.config.get('update');

		if (this.update) {
			// Use the real latest version instead of the cached one
			this.update.current = this.packageVersion;

			// Clear cached information
			this.config.delete('update');
		}

This is a bit weird to me, wouldn't it be better if the update message was displayed consistently as long as there is an update? Some users might miss that there is an available update quite easily.

Some workarounds I'm using to ensure that once an update gets fetched, it remains visible, and trying to fetch it before the first interval:

// Hacky way to ensure we check for updates on first run
// Note: the notification will only happen in the 2nd run anyway
if (
  !notifier.disabled &&
  Date.now() - notifier.config.get('lastUpdateCheck') < 50
) {
  notifier.config.set('lastUpdateCheck', 0);
  notifier.check();
}

if (notifier.update && notifier.update.current !== notifier.update.latest) {
  // Because notifier clears cached data after reading it, leading to notifier not consistently displaying the update
  notifier.config.set('update', notifier.update);

  // Display notification
}

Having a more convenient way to achieve all this could be useful

Guide contributeur