sindresorhus/eslint-plugin-unicorn

`no-unnecessary-polyfills`: respect `.browserslistrc`

Open

#2 389 ouverte le 24 juin 2024

Voir sur GitHub
 (0 commentaires) (2 réactions) (0 assignés)JavaScript (5 022 stars) (468 forks)user submission
enhancementevaluatinghelp wanted

Description

Description

Currently it will respect a browserlist field in package.json but it would be great if it could also respect the .browserslistrc file.

This will be a little more complicated though as that file can define multiple targets, so an option as to which target to respect would also need to be added, defaulting to production.

Fail

# .browserslistrc

[production]
since 2024

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Pass

# .browserslistrc

[production]
since 2020

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Additional Info

No response

Guide contributeur

Stack technique
javascriptnodejs
Domaine
toolingdeveloper experience
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Basic understanding of ESLint pluginsFamiliarity with browserslistWorking knowledge of Node.js file system
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
Examine the current implementation of browserslist support in the plugin, likely in the `no unnecessary polyfills` rule. Look for how the `browserslist` field from `package.json` is read and used. Then implement parsing of `.browserslistrc` file, which can have multiple sections. Add a new option (e.g., `browserslistTarget`) defaulting to `production`. Ensure to use the `browserslist` package's API for parsing configuration. Consider integrating with existing logic to merge options. No PR linked; the issue has no comments.