sindresorhus/eslint-plugin-unicorn

Improve `prefer-set-has`

Fermée

#1 338 ouverte le 4 juin 2021

 (2 commentaires) (3 réactions) (0 personne assignée)JavaScript (468 forks)user submission
enhancementhelp wanted

Métriques du dépôt

Stars
 (5 022 étoiles)
Métriques de merge PR
 (Merge moyen 1j 16h) (399 PRs mergées en 30 j)

Description

Currently, we only report cases that Array only called .includes(). But in some other cases, it should still be preferred.

const foo = [1, 2, 3];

if (foo.includes(1));

// Still work the same if we use `Set`
for (const element of foo);
const bar = [...foo, somethingElse];
call(...foo);
const length = foo.length; // Use `.size` when switch to Set

// Even this, if the callback don't use the second parameter, they are the same
foo.forEach(element => call(element));

We only need make sure the original Array have unique values.

Guide contributeur