sindresorhus/electron-dl

BUG: Promise is not working correctly

Ouverte

#67 ouverte le 5 juil. 2018

 (3 commentaires) (3 réactions) (0 personne assignée)JavaScript (136 forks)user submission
bughelp wanted

Métriques du dépôt

Stars
 (1 206 étoiles)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

#66

download This library works correctly for same syntax

Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(x, 'dist');
})).then(function () {
    console.log('files downloaded!');
});

electron-dl: while using same with electron-dl does not. Promise returns before downloads


  Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(BrowserWindow.getFocusedWindow(), x);
  })).then(function (x) {
    console.log('files downloaded!');
  });

Guide contributeur