schickling/chromeless

Windows Build Compatibility

Open

#70 ouverte le 28 juil. 2017

Voir sur GitHub
 (5 commentaires) (0 réactions) (0 assignés)TypeScript (13 240 stars) (606 forks)batch import
APIProxyhelp wanted

Description

I found a couple issues while trying to build this on Windows.

  1. For "npm run build" --> "rm -rf dist; tsc -d"

    • "rm -rf dist;" doesn't make sense on windows since the rm command doesn't exist. The command to remove a directory in windows is "rmdir"
    • I'm open to suggestions on how to solve this one, my only thought is to have 2 different build scripts (one for windows and one for mac/linux)

  2. https://github.com/graphcool/chromeless/blob/master/src/chrome/local-runtime.ts#L204-L205

    • This line sets the tmp directory as "/tmp". On windows this refers to "C:/tmp". I think we should change this line to refer to just "tmp/" so that it refers to a tmp folder inside the current directory.
    • Also, fs.writeFileSync() assumes the tmp folder exists, I think we need code in here to check for the folder and add the folder if it doesn't exist.

Once we have solid solutions to these 2 things, I can implement a PR.

Guide contributeur

Stack technique
typescriptnodejs
Domaine
build system
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Node.js basicsnpm scriptsWindows environment
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
80
Direction de recherche
Review the issue comments for any suggested solutions or additional context. The main changes involve modifying the build script in package.json to use a cross platform tool like rimraf instead of 'rm rf dist', and updating the tmp directory path in src/chrome/local runtime.ts from '/tmp' to use os.tmpdir() or a relative path. Additionally, ensure the tmp directory exists before writing using fs.existsSync() or mkdirSync. Test the changes on a Windows machine to confirm compatibility.