rust-lang/rustfmt

Option to ignore modules that cannot be resolved

Open

#5 609 ouverte le 18 nov. 2022

Voir sur GitHub
 (4 commentaires) (0 réactions) (0 assignés)Rust (760 forks)batch import
C-feature-requestP-lowgood first issue

Métriques du dépôt

Stars
 (4 893 stars)
Métriques de merge PR
 (Merge moyen 10j 21h) (8 PRs mergées en 30 j)

Description

Hi

I am working on async-stripe which generates rust files and run into frequent errors in my automatic CI pipeline when they (the upstream openapi) remove parts of the api surface, as those modules are still referenced in the manual written mod.rs files. The automatic codegen runs, rustfmt is applied, and it fails due to missing files.

Now, I could (and will in the mean time) just set the rustfmt step as optional and apply it manually as these cases need to be manually intercepted, but I would love it if that, rather than eagerly fail, there was an opt-in option to simply prune the modules that now no-longer exist such that it can recover and format the ones that do.

Formatting is then also checked in the subsequent PR that is generated, but it would be nice to have the PR be created with formatting applied at a best-effort level.

See https://github.com/arlyon/async-stripe/actions/runs/3493571680/jobs/5848542195

Cheers,

Alex

Guide contributeur