rust-lang/rust-clippy
Voir sur GitHubrc_buffer lint is dangerous as it changes runtime behaviour
Open
#6 170 ouverte le 13 oct. 2020
C-bugL-suggestiongood first issue
Métriques du dépôt
- Stars
- (10 406 stars)
- Métriques de merge PR
- (Merge moyen 19j 22h) (113 PRs mergées en 30 j)
Description
clippy warns if one tries to use a type like Rc<Vec<T>>, e.g.
Arc<Vec<u8>>
^^^^^^^^^^^^ help: try: `Arc<[u8]>`
This is dangerous as creating a Rc<[T]> causes a memcpy of the whole memory area with all the elements, while creating an Rc<Vec<T>> simply copies over the 3 pointers inside the Vec without copying all the elements.
A better suggestion would probably be Rc<Box<[T]>> as that has the same runtime behaviour, but even independent of that it can be useful to have a Vec inside an Rc / Arc in combination with the make_mut() / get_mut() API.
The lint should probably be at least disabled by default.
The same also applies to Rc<String> vs Rc<str>.