rust-lang/rust-clippy
Voir sur GitHub`use_debug` lint should not trigger on `debug!()` log macro calls
Open
#2 132 ouverte le 12 oct. 2017
C-enhancementT-middlegood first issue
Métriques du dépôt
- Stars
- (10 406 stars)
- Métriques de merge PR
- (Merge moyen 19j 22h) (113 PRs mergées en 30 j)
Description
Example use-case:
#![cfg_attr(feature = "cargo-clippy", warn(use_debug))]
#[macro_use]
extern crate log;
pub fn euclid_steps(mut x: u64, mut y: u64) -> Vec<u64> {
debug!("x = {}, y = {}", x, y);
let mut steps = vec![];
loop {
let tmp = x % y;
if tmp == 0 {
debug!("Steps performed in Euclidean algorithm: {:?}", steps);
return steps;
}
steps.push(tmp);
x = y;
y = tmp;
}
}
Placing #![cfg_attr(feature = "cargo-clippy", allow(use_debug))] before each debug!() usage seems tedious to me when there are several dozens of them; and turning it off (even if locally) defeats the purpose of the lint.