rust-lang/rust-clippy

Always true expressions in if expressions

Open

#1 593 ouverte le 3 mars 2017

Voir sur GitHub
 (3 commentaires) (0 réactions) (1 assigné)Rust (1 391 forks)batch import
A-lintL-correctnessT-middlegood first issue

Métriques du dépôt

Stars
 (10 406 stars)
Métriques de merge PR
 (Merge moyen 19j 22h) (113 PRs mergées en 30 j)

Description

I'd like Clippy to find this problem in the code, this expression is always true, and Clippy should also suggest the usage of && here instead:

fn foo1a(name: &str) {
    if name != "Min" || name != "Max" {}
}

Another example:

fn foo1b(x: i32) -> bool {
    x > 10 || x < 25
}

Guide contributeur