rtfeldman/seamless-immutable

`merge` ignores Symbols contrary to `set`

Ouverte

#189 ouverte le 28 déc. 2016

 (0 commentaire) (0 réaction) (0 personne assignée)JavaScript (221 forks)batch import
bughelp wanted

Métriques du dépôt

Stars
 (5 367 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Using Immutable 7.0.1, Babel, and Node 6, it seems that merge skips properties where the key is a Symbol, while set (correctly) sets them. It works with normal objects. Example:

babel> const Immutable =  require('seamless-immutable');
babel> const s = Symbol("sym mine");
babel> Immutable({}).merge({[s]: "sym val"})[s]
undefined // WRONG: expected 'sym val'
babel> Immutable({}).set(s, "sym val")[s]
'sym val' // CORRECT

However it works when the key is not a Symbol but a normal object:

> var Immutable =  require('seamless-immutable');
> var s = {name: "key obj"};
> Immutable({}).merge({[s]: "sym val"})[s]
'sym val'

Guide contributeur