rtfeldman/seamless-immutable

Does not work with Javascript Maps

Open

#171 ouverte le 14 nov. 2016

Voir sur GitHub
 (9 commentaires) (0 réactions) (0 assignés)JavaScript (5 367 stars) (221 forks)batch import
enhancementhelp wanted

Description

I am using a javacript map to store data I retrieve from an api for a udacity project.

However, the data is not being saved to the immutable object.

here is a branch you can clone and verify:

  1. clone https://github.com/noahehall/udacity-trainschedule/tree/serviceworkers
  2. npm install
  3. npm run start

here is picture of implementation

here is picture of error received from immutable error TypeError: immutableDoesNotWorkWithJavascriptMaps.data.has is not a function(…)

Is there a workaround to get immutable to use Javascript maps? am i doing something wrong (very likely...)? or should I abandon seamless immutable?

Guide contributeur

Stack technique
javascript
Domaine
data
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
JavaScriptMap objectimmutable data concepts
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
The issue requests support for JavaScript Map objects in seamless immutable. Currently, the library only handles plain objects and arrays. To implement, examine the immutable wrapper pattern for objects (e.g., overriding get, set, etc.) and adapt it for Map. The user provided a reproduction branch (https://github.com/noahehall/udacity trainschedule/tree/serviceworkers). Review comments for any maintained guidance. The fix would involve creating an ImmutableMap class that mirrors the API but uses Map's internal storage.