rstudio/plumber

POST bodies that can't be parsed should return HTTP 415 Unsupported Media Type

Open

#767 ouverte le 8 févr. 2021

Voir sur GitHub
 (5 commentaires) (2 réactions) (0 assignés)R (257 forks)batch import
effort: lowhelp wantedtheme: postBody

Métriques du dépôt

Stars
 (1 437 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

At present, if you decorate a POST endpoint with a parser (e.g. @parser json), and the client does not send you JSON data, you'll just see a message in the console and the endpoint handler will run anyway (even though, presumably, it will fail).

I don't think this is a particularly good way to surface errors to either the client or the operator -- even with the server logs, one can't use a generic message to track down which request had the problem.

Since this is a client error, the client should get a HTTP 4xx response. It turns out there is an existing HTTP status code for exactly this situation: 415 Unsupported Media Type. I'd like to see this returned instead. And, as with #757, I'd ideally like the response body/headers to be controllable.

Guide contributeur