rochacbruno/python-project-template

Writing new VERSION on MacOSX

Open

#22 ouverte le 20 juin 2022

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)Makefile (184 forks)github user discovery
bughelp wanted

Métriques du dépôt

Stars
 (1 224 stars)
Métriques de merge PR
 (Métriques PR en attente)

Description

Describe the bug When I do make relase On my MacOSX. It cannot write properly VERSION file. This is due to the read command which is not working as expected in zsh.

To Reproduce Steps to reproduce the behavior: Run make release on a zsh shell.

Expected behavior

@echo "WARNING: This operation will create s version tag and push to github"
@read -p "Version? (provide the next x.y.z semver) : " TAG
@echo "$${TAG}" > project_name/VERSION

The TAG variable will always be voiid and thus the VERSION file will be emplty. No release actions will be triggered in github.

Desktop (please complete the following information):

  • OS: [macOS 12.0.1]
  • Zsh [zsh 5.8 (x86_64-apple-darwin21.0)]

Additional context For the moment I change by hand the version number in VERSION file. And I changed Makefile with: VERSION=$(shell cat checkatlas/VERSION)

@echo "Reading version $(VERSION) from: checkatlas/VERSION"
@$(ENV_PREFIX)gitchangelog > HISTORY.md
@git add checkatlas/VERSION HISTORY.md
@git commit -m "release: version $(VERSION) 🚀"

Guide contributeur