replicatedhq/ship
Config Options of type "label" should not be written to state.json
Ouverte
#906 ouverte le 10 avr. 2019
good first issuetype::bug
Métriques du dépôt
- Stars
- (635 étoiles)
- Métriques de merge PR
- (Métriques PR en attente)
Description
Expected behavior
With this config item:
- name: https_label
when: '{{repl ConfigOptionEquals "enable_ssl" "1" }}'
title: Requests will be encrypted. HTTP requests will be redirected to HTTPS.
type: label
is used, it should not have any effect on state.json, as its merely around presentation logic.
Actual behavior
The following is added to state.json#config.v1
"https_label": "",
Information
- Ship version: 0.39.0
Steps to reproduce
Use the following ship.yaml
assets:
v1: []
config:
v1:
- name: group
items:
- name: https_label
when: '{{repl ConfigOptionEquals "enable_ssl" "1" }}'
title: Requests will be encrypted. HTTP requests will be redirected to HTTPS.
type: label
lifecycle:
v1:
- config: {}
- render: {}
and then
ship init path/to/yaml
then inspect state.json
cat .ship/state.json