react/create-react-app

Allow JSON with comments in jsconfig.json

Open

#7 426 ouverte le 25 juil. 2019

Voir sur GitHub
 (15 commentaires) (0 réactions) (0 assignés)JavaScript (103 386 stars) (27 059 forks)batch import
contributions: claimeddifficulty: mediumgood first issueissue: proposal

Description

Is your proposal related to a problem?

This is a follow-on from #7248. Right now, we don't support JSONC (JSON with comments) in jsconfig.json files.

Describe the solution you'd like

After a discussion with @iansu, we see two paths:

  1. Implement the same solution as we did for TypeScript. This is easy, but would require us making TypeScript a dependency of react-scripts.
  2. The above, but instead of installing typescript as a dependency of react-scripts, we would install it to the user's project if they are using a jsconfig.json file and don't have typescript installed.

Discussion is welcome.

If you're interested in picking this up, please let us know.

Guide contributeur

Stack technique
javascripttypescript
Domaine
frontendtoolingbuild system
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Familiarity with JSONCUnderstanding of jsconfig.jsonKnowledge of React scriptsBasic understanding of TypeScript dependency
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
40
Direction de recherche
Read the linked issue #7248 to understand previous discussions. Evaluate the two proposed solutions: implementing TypeScript support as done for TypeScript (requires making TypeScript a dependency) or installing TypeScript only for jsconfig users without it. Check if the community has expressed a preference. Look at the current codebase to see how tsconfig.json is handled for TypeScript projects. The issue lacks a final decision, so the contributor should propose a clear plan or seek maintainer input.