rapidsai/cudf
Voir sur GitHub[FEA] Change cudf::io::detail::make_column() to have a more verbose name.
Open
#11 391 ouverte le 28 juil. 2022
cuIOgood first issueimprovementlibcudfproposal
Métriques du dépôt
- Stars
- (6 000 stars)
- Métriques de merge PR
- (Merge moyen 17j 21h) (230 PRs mergées en 30 j)
Description
std::unique_ptr<column> make_column(column_buffer& buffer,
column_name_info* schema_info,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
This is kind of a weakly named global function. Because its name is so generic, it doesn't play nice with users who might want to create their own, more appropriately named make_column that does some other work along the way. Changing this to column_from_column_buffer() or make_column_from_buffer(), or maybe making it a member of column_buffer would clean things up a bit
Eg.
// user function (in parquet code for example)
make_column(column_buffer &b)
{
// random preprocessing work
auto x = column_from_column_buffer(b);
// random postprocessing work
}