[Bug] Weak mods not cleared properly when using Layer Tap and quicky tapping shifted keycodes.
#17 569 ouverte le 5 juil. 2022
Métriques du dépôt
- Stars
- (20 368 stars)
- Métriques de merge PR
- (Merge moyen 20j 9h) (27 PRs mergées en 30 j)
Description
Describe the Bug
Have LT(1, KC_SPACE), on layer one, have KC_COLN (shifted semicolon), and KC_LBRC (not shifted). If you hit LT, then the colon, and then any non-shifted key, it will be shifted.
Eg, this should produce: :] but will produce :}. Not every time, but if you do this fast enough, it will happen consistently.
I have tracked this down to the code change in #9941. However reverting this breaks a number of other pathways. Even partially reverting it (adding the clear weak mods to both sections).
it may be possible to fix the other features, as well, but.....
System Information
Keyboard: Moonlander, Charybdis, Ergodox EZ
Revision (if applicable): N/A
Operating system: MacOS, Windows
qmk doctor output: Not relevant to this
Any keyboard related software installed?
- AutoHotKey (Windows)
- Karabiner (macOS)
- Other:
Additional Context
Explicitly reverting the code change from #9941 fixes the issue. But breaks other features, such as caps words.
@IsaacElenbaas @getreuer a heads up