[Bug] PrimeKB/Meridian LED indicator lights won't turn off. · qmk/qmk_firmware#11755

2021-02-01T02:31:09.000Z

[Meridian](https://github.com/qmk/qmk_firmware/tree/master/keyboards/primekb/meridian)'s LED indicator lights won't turn off. Further more, it seems like `rgblight_setrgb_at` can no longer control the LEDs, which was previously working in the [initial commit](https://github.com/qmk/qmk_firmware/commit/f079dd90ed88fd29b7e5bbdd3496742f3afeff4e). ## Describe the Bug It seems like `rgblight_setrgb_at` no longer works properly for the Meridian firmwares (both VIA & default) on master. I'm not sure what could have caused it or if other STM32 related PCBs have the same issue. After git-bitsecting, I have narrowed it down to [this commit](https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552) to be the source of the problem. ## System Information - Keyboard: - Revision (if applicable): [PrimeKB/Meridian](https://github.com/qmk/qmk_firmware/tree/master/keyboards/primekb/meridian) (revision master) - Operating system: `macOS Mojave (v10.14.6)` - AVR GCC version: `avr-gcc (Homebrew AVR GCC 8.4.0) 8.4.0` - ARM GCC version: `arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]` - QMK Firmware version: `0.11.56` - Any keyboard related software installed? - [ ] AutoHotKey - [x ] Karabiner - [ ] Other: ## Additional Context - `git-bitsect` points to this commit to be the source of the problem: https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552.

Métriques du dépôt

Stars: (20 368 stars)
Métriques de merge PR: (Merge moyen 20j 9h) (27 PRs mergées en 30 j)

Description

Meridian's LED indicator lights won't turn off. Further more, it seems like rgblight_setrgb_at can no longer control the LEDs, which was previously working in the initial commit.

Describe the Bug

It seems like rgblight_setrgb_at no longer works properly for the Meridian firmwares (both VIA & default) on master. I'm not sure what could have caused it or if other STM32 related PCBs have the same issue. After git-bitsecting, I have narrowed it down to this commit to be the source of the problem.

System Information

Keyboard:
- Revision (if applicable): PrimeKB/Meridian (revision master)
Operating system: macOS Mojave (v10.14.6)
AVR GCC version: avr-gcc (Homebrew AVR GCC 8.4.0) 8.4.0
ARM GCC version: arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]
QMK Firmware version: 0.11.56
Any keyboard related software installed?
- AutoHotKey
- [x ] Karabiner
- Other:

Additional Context

git-bitsect points to this commit to be the source of the problem: https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552.

Guide contributeur

Direction de recherche: Examinez le commit c66df1664497546f32662409778731143e45a552 pour voir les modifications qui ont affecté rgblight setrgb at sur les claviers basés sur STM32 comme le Meridian. Tracez le chemin du code de l'indicateur LED et testez avec une build de débogage sur un matériel similaire.
Stack technique: c
Domaine: embedded iot
Type d'issue: Bug
Difficulté: 3
Temps estimé: Une demi journée
Statut d'activité: Active
Clarté: Plutôt claire
Prérequis: GitCQMK basics
Accessibilité débutant: 50