pymc-devs/pymc

Compute only dependent logp in step samplers

Ouverte

#7 591 ouverte le 26 nov. 2024

 (0 commentaire) (0 réaction) (0 personne assignée)Python (1 902 forks)batch import
enhancementshelp wantedsamplers

Métriques du dépôt

Stars
 (7 926 étoiles)
Métriques de merge PR
 (Merge moyen 11j) (7 PRs mergées en 30 j)

Description

Description

As discussed in: https://discourse.pymc.io/t/semantik-description-of-kruschke-diagrams-model-to-graphviz/16142/8 we could be making more use of the conditional partition of the logp graph for partial step samplers.

When the proposal depends on a ratio between probabilities (BinaryMetropolois, BinaryGibbsMetropolis, CategoricalGibbsMetropolis, Slice, NUTS), we don't need to compute terms that don't depend on the updated variables.

Step samples that explicitly request delta_logp (Metropolis, DEMetropolis) achieve this implicitly via PyTensor rewrites.

I suggest adding a model.dependent_logp(vars) that helps us get the logp we need (the variables of interest + conditional dependent variables)

Guide contributeur