pymc-devs/pymc

CheckParameterValues not replaced in inner graphs

Open

#6 697 ouverte le 28 avr. 2023

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)Python (1 902 forks)batch import
help wantedlogprob

Métriques du dépôt

Stars
 (7 926 stars)
Métriques de merge PR
 (Merge moyen 11j 6h) (12 PRs mergées en 30 j)

Description

We include these rewrites when compiling logp graphs, but this won't replace inner logp graphs (e.g, inside Scan or not-inlined OpFromGraph)

https://github.com/pymc-devs/pymc/blob/371472dcf1c44f99a9ad4e7317606404b2a47a0e/pymc/pytensorf.py#L1142-L1144

The example in #6696 suffers from this. Sampling is quite faster when the rewrite is manually added

Guide contributeur