pyjanitor-devs/pyjanitor

[ENH] add_column fix

Open

#408 ouverte le 13 juil. 2019

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)Python (164 forks)batch import
enhancementgood first issuegood intermediate issue

Métriques du dépôt

Stars
 (1 217 stars)
Métriques de merge PR
 (Merge moyen 2j 12h) (4 PRs mergées en 30 j)

Description

Currently, the add_column function contains the parameter fill_remaining. I believe this parameter could be combined with the value parameter, such that when a list or tuple is inputted into value, it should automatically repeat to fill up the remainder of the column rather than having to specify that in another parameter (fill_remaining). (Also, whenever a list/tuple of a different size from the number of rows is inputted anyway, there is an error. So in my opinion, it would be more efficient to just automatically have the list/tuple iterate until it fills up the remainder of the column solely through inputting the list/tuple into the values parameter rather than also having the fill_remaining parameter.)

is also due to inputting a tuple/list of a different size than the column size will lead to an error anyway)

Relevant Context

Guide contributeur