pwndbg/pwndbg

Move saving of old regs to context regs?

Open

#3 522 ouverte le 21 déc. 2025

Voir sur GitHub
 (11 commentaires) (0 réactions) (0 assignés)Python (5 820 stars) (776 forks)batch import
code cleanupenhancementgood first issuehelp wanted

Description

https://github.com/pwndbg/pwndbg/blob/a5651663fae15c17aaa4ffe96055e074e19f8b4e/pwndbg/aglib/regs.py#L315-L323

TL;DR:

  • we keep last & previous registers as of today
  • this is only needed to highlight the registers whose values differ from the previous one when displaying registers in the context (can be done with just regs or when set context-sections regs was done)

But... if one doesn't display regs in context, this keeping track still happens.

So maybe we should move it to context_regs function instead?

There are some disadventages to this - if regs would be not displayed, the keeping track is not happening. But do we care that much?

Guide contributeur

Stack technique
python
Domaine
developer experience
Type d'issue
refactor
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
pwndbg internalsGDB basics
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
The issue discusses moving the saving of old/previous register values from the generic regs module to the context regs function in pwndbg/aglib/regs.py:315-323. To proceed, examine how register values are currently stored and used for highlighting differences in context display. Investigate the trade offs: moving it may cause loss of history if regs are not displayed, but reduces overhead. Check if there are other places that rely on old register values. The maintainer's question indicates this is an open design decision.