publiclab/mapknitter

Errors in latest code to resolve before publishing to live site

Ouverte

#1 128 ouverte le 5 déc. 2019

 (4 commentaires) (0 réaction) (0 personne assignée)Ruby (203 forks)auto 404
break-me-upbughelp wanted

Métriques du dépôt

Stars
 (274 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Hi! I'm just getting things closer to a new release we can publish to the live site, and writing down a variety of small bugs I found that I think need to be addressed before this is ready to publish. I'm sure we can do this!

  • After uploading 3 images, i found the Images tab had 3 copies of the same image instead of the 3 different images. This resolved on page reload (maybe @divyabaid16 or @cesswairimu ?)
  • Newly placed images could sometimes not be selected by clicking on them. i clicked on other things for a while before I was able to click to select them.
  • I can't seem to set the multi export scale; this used to create a prompt! Now it's set to 100 no matter what. @sashadev-sky was this taken out of the default multi-exporter? (moved to publiclab/Leaflet.DistortableImage#471)
  • we can no longer zoom in very close; it used to allow up to something like zoom 18 or 20, but we're now limited to much lower; #156 perhaps related? See below. (moved to https://github.com/publiclab/mapknitter/issues/1138)

image

Finally, I think some tools (scale, simple rotate (not free rotate), and drag) should be hidden or tucked into a submenu, as they're not critical and make the menu a little overwhelming for newcomers.

I'd love help figuring these out, and then we can get closer to publishing this to the live site!

You can try this all out here:

http://mapknitter-stable.laboratoriopublico.org/maps/lee-nh/edit

Guide contributeur