Aggregation function arbitrary should be order sensitive
#21 786 ouverte le 25 janv. 2024
Métriques du dépôt
- Stars
- (15 558 étoiles)
- Métriques de merge PR
- (Merge moyen 34j 14h) (120 PRs mergées en 30 j)
Description
Hi ,
We have found that arbitary aggregate function is order sensitive as the resultant value can change across runs. This happens despite setting ORDER BY as it doesnt honor the order sensitivity flag.
Aggregation functions that are marked as order sensitive allows user to use ORDER BY within the aggregation function call to specify an order of input. (https://prestodb.io/docs/current/functions/aggregate.html#functions-aggregate--page-root).
Your Environment
N/A
Expected Behavior
SELECT ARBITRARY(x ORDER BY x) from SOME_LARGE_TABLE; -- This table has column x
Should return same result across multiple runs.
Current Behavior
The above should ideally always return the same result , however the value returned is indeterminate.
Possible Solution
The arbitary aggregate function can be marked as order sensitive as shown below:
Context
The Velox team is trying to ensure correctness of its aggregate functions, Because Presto's arbitary is not marked order_sensitive its harder to validate its Velox equivalent.