pnpm/pnpm

`pnpm store status` + `pnpm install` doesn't refetch

Open

#919 ouverte le 24 oct. 2017

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)TypeScript (30 787 stars) (1 063 forks)batch import
help wantedtype: feature

Description

pnpm store status

     These packages are modified:
     /Users/Vaughan/.pnpm-store/2/registry.npmjs.org/ajv-keywords/2.1.0/ajv@5.3.0
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/babel-loader/7.1.2/babel-core@6.26.0+webpack@3.6.0
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/glob-promise/3.2.0/glob@7.1.2
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/next/4.1.3
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/stylis-rule-sheet/0.0.6/stylis@3.3.2
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/uglifyjs-webpack-plugin/0.4.6/webpack@3.6.0
/Users/Vaughan/.pnpm-store/2/registry.npmjs.org/webpack-dev-middleware/1.12.0/webpack@3.6.0

     You can run pnpm install to refetch the modified packages

pnpm install

pnpm store status

Same packages as above show, minus next, which is the only one used in my project.

  1. It didn't seem to actually refetch the packages - the package next doesn't show up anymore in the pnpm store status, but it still has changes.

  2. Is it checking all packages in the store, or just for this project? Seems like the entire store.

  • If this is the case, it should not say pnpm install will fix it.

  • Could we also have a command that will fix the entire store?

  • And maybe also have a command that will only refetch the packages that have changed, so that we don't have to run an entire pnpm install operation, which may be slow.

Guide contributeur

Stack technique
typescriptnodejs
Domaine
clitooling
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
needs investigation
Prérequis
Basic knowledge of pnpm package managerFamiliarity with Node.js/TypeScriptUnderstanding of pnpm store internals
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
40
Direction de recherche
Investigate the `pnpm store status` command to understand how it detects modified packages. Then examine the `pnpm install` command to see why it does not refetch all modified packages when `store status` indicates modifications. Look at files in the `src/` directory related to store and install, such as `src/storeStatus.ts` and `src/install.ts`. Consider whether the fix should only check packages relevant to the project or the entire store, and whether a new command to refetch only modified packages is needed.