patchthecode/JTAppleCalendar

Selecting a large date range all at once shows a delay before loading app [Expected]. Suggestions wanted on how to improve this code.

Ouverte

#1 201 ouverte le 27 déc. 2019

 (12 commentaires) (0 réaction) (1 personne assignée)Swift (819 forks)batch import
help wanted

Métriques du dépôt

Stars
 (7 660 étoiles)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Version Number: 8.0.2

Description

Function "selectDates(from startDate: Date, to endDate: Date, triggerSelectionDelegate: Bool = true, keepSelectionIfMultiSelectionAllowed: Bool = false)" freeze main thread in my app when I pass too long period between startDate and endDate (about six and more months).

Steps To Reproduce

func calendar(_ calendar: JTACMonthView, didSelectDate date: Date, cell: JTACDayCell?, cellState: CellState, indexPath: IndexPath) {
               var selectedDates = calendar.selectedDates
               if let start = selectedDates.min(), let end = selectedDates.max() {
                              calendar.selectDates(from: start, to: end, triggerSelectionDelegate: false, keepSelectionIfMultiSelectionAllowed: true)
               }
}

Expected Behavior

Not freeze main thread in app for a few seconds

Guide contributeur