pallets-eco/flask-wtf

Inconsistency with raising CSRFError

Ouverte

#381 ouverte le 18 oct. 2019

 (2 commentaires) (0 réaction) (0 personne assignée)Python (315 forks)github user discovery
csrfdocsgood first issue

Métriques du dépôt

Stars
 (1 508 étoiles)
Métriques de merge PR
 (Merge moyen 3h 45m) (3 PRs mergées en 30 j)

Description

The Flask-WTF docs state:

When CSRF validation fails, it will raise a CSRFError.

However, this appears to only be true, if this optional code has been used:

from flask_wtf.csrf import CSRFProtect
csrf = CSRFProtect(app)

When that code is not used, forms are created by subclassing FlaskForm, and CSRF validation fails, then validate_on_submit returns False instead of raising CSRFError.

It seems that ideally you would always raise CSRFError for consistency, but if you don't want to do that, then it would be helpful to update the docs.

Guide contributeur