palantir/blueprint

FR: Support small modifier for NumericInput

Open

#3 132 ouverte le 7 nov. 2018

Voir sur GitHub
 (2 commentaires) (1 réaction) (0 assignés)TypeScript (20 263 stars) (2 167 forks)batch import
P3Package: coreType: feature requesthelp wanted

Description

Environment

  • Package version(s): 3.8
  • Browser and OS versions: Chrome 70

Feature request

I like to make a form using small modifier on components. I can use small modifier on InputGroup and Button but MenuItem and NumericInput does not support small modifier. I tried className={Classes.SMALL} but it did not work. You can look at screenshot below as an example

Could you implement support for these components? Probably there are other components that does not support small modifier. I prefer support for all components which can be used inside a form.

Examples

<Button small={true} rightIcon="double-caret-vertical" .../> <InputGroup small={true} .../> <NumericInput leftIcon="arrow-top-left" .../> // does not support small modifier <NumericInput .../>

Guide contributeur

Stack technique
typescriptreact
Domaine
frontend
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Familiarity with Blueprint component patternsUnderstanding of TypeScript and React
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
The issue requests adding a 'small' modifier to NumericInput, similar to existing support in Button and InputGroup. Research the implementation of the 'small' prop in those components (e.g., Button.tsx and InputGroup.tsx) to understand the pattern. Then examine NumericInput.tsx and its associated styles in numeric input.scss to add the Small modifier. The issue mentions that className={Classes.SMALL} did not work, so the fix likely involves adding a prop or CSS class that applies the small size styling. There are no linked PRs or maintainer comments, so the implementation is straightforward and can follow the existing pattern.