palantir/blueprint

EditableText: support additional editing customisation [feature request]

Open

#1 393 ouverte le 27 juil. 2017

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)TypeScript (20 263 stars) (2 167 forks)batch import
Package: coreType: enhancementhelp wanted

Description

It would be convenient to have more control around the edit process.

My motivating example is to differentiate display-value vs edit-value; for example display a formatted currency string "$1,234.50", but present the raw number (1234.5) for editing.

I can think of a few possibilities off the top of my head to implement this:

  • an optional format function
  • different properties for display and editing values
  • a callback fired before editing starts
  • (more involved) a different component for editing, meaning you could also use a select list on edit, or a colour picker, etc

I'm not sure which might be the best solution, if this is desirable functionality, but I'm happy to work on a patch for feedback if necessary.

Guide contributeur

Stack technique
reacttypescript
Domaine
frontend
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
ReactTypeScriptBlueprint component patterns
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
40
Direction de recherche
Explore the EditableText component source in the Blueprint repository to understand current implementation. Evaluate the feasibility of the proposed approaches (format function, separate props, callback, etc.) considering backward compatibility. Check issue comments for maintainer preferences and any rejected or preferred solutions. Focus on implementing a simple format function or a callback before editing to start.